07-08-2017, 06:13 PM
Just gave it a shot. Some issues with the installation
- creates shortcut on desktop even when I deselect it.
- no uninstaller available. Apart from the program-location, the installer creates a folder in "Appdata\Local\LF-Empire Client" (if anybody plans on full removal). Might want to include the uninstaller for future releases.
Here are some things I noticed while tinkering around:
[bug] When you delete the LF2-path, you'll get greeted by a "Path has invalid format"-message
[bug] When you manually enter a path, exceptions will be thrown with each keypress. Things like "Access Denied" or "Path does not exist".
[bug] Having invalid paths will trigger standard exception dialogs as well.
[feature req] Do a loading screen animation thingy when the program starts up instead of a lockup during initial bootup.
[feature req] possibility to actually uninstall (not just delete contents) downloads as explained by Gad.
[feature req] parse HTML entities. Ex: "Goku & SSJ Goku"
[question] How are installations handled when two characters have equally named files? Ex: both zips contain a file called "XYZ.wav". Will the second character replace the first one's data? If that is the case: [fix] add suffix to second installation and modify the dat-file accordingly.
[feature req] Not only keep track of downloaded files but also which were installed.
[feature req] Handle ID clashes. During installation of the character, warn that the ID is already existing in data.txt. If there are multiple files from different downloads that point to the same
Gameplay works nicely, though. Good work so far!
- creates shortcut on desktop even when I deselect it.
- no uninstaller available. Apart from the program-location, the installer creates a folder in "Appdata\Local\LF-Empire Client" (if anybody plans on full removal). Might want to include the uninstaller for future releases.
Here are some things I noticed while tinkering around:
[bug] When you delete the LF2-path, you'll get greeted by a "Path has invalid format"-message
Code:
System.ArgumentException: The path has an invalid format.
at System.IO.Path.NormalizePath(String path, Boolean fullCheck, Int32 maxPathLength, Boolean expandShortPaths)
at System.IO.Path.GetFullPathInternal(String path)
at System.IO.FileSystemEnumerableIterator`1..ctor(String path, String originalUserPath, String searchPattern, SearchOption searchOption, SearchResultHandler`1 resultHandler, Boolean checkHost)
at System.IO.Directory.GetFiles(String path)
at LittleFighterEmpire_Client.class_LF_ReaderStuff.getListOfFiles(String path, String pattern)
at LittleFighterEmpire_Client.class_LF_ReaderStuff.getDataTxt(String path)
at LittleFighterEmpire_Client.index_v3.txt_lf_path_TextChanged(Object sender, EventArgs e)
at System.Windows.Forms.Control.OnTextChanged(EventArgs e)
at System.Windows.Forms.TextBoxBase.OnTextChanged(EventArgs e)
at System.Windows.Forms.TextBoxBase.WmReflectCommand(Message& m)
at System.Windows.Forms.TextBoxBase.WndProc(Message& m)
at System.Windows.Forms.TextBox.WndProc(Message& m)
at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)
[bug] Having invalid paths will trigger standard exception dialogs as well.
[feature req] Do a loading screen animation thingy when the program starts up instead of a lockup during initial bootup.
[feature req] possibility to actually uninstall (not just delete contents) downloads as explained by Gad.
[feature req] parse HTML entities. Ex: "Goku & SSJ Goku"
[question] How are installations handled when two characters have equally named files? Ex: both zips contain a file called "XYZ.wav". Will the second character replace the first one's data? If that is the case: [fix] add suffix to second installation and modify the dat-file accordingly.
[feature req] Not only keep track of downloaded files but also which were installed.
[feature req] Handle ID clashes. During installation of the character, warn that the ID is already existing in data.txt. If there are multiple files from different downloads that point to the same
oid:
, refactor them. Keep a list of IDs that have hardcoded properties and warn if an installed, refactored file would be affected.Gameplay works nicely, though. Good work so far!
Silverthorn / Blue Phoenix
~ Breaking LFE since 2008 ~
"Freeze, you're under vrest!" - Mark, probably.
» Gallery | » Sprites | » DeviantArt
~ Breaking LFE since 2008 ~
"Freeze, you're under vrest!" - Mark, probably.
» Gallery | » Sprites | » DeviantArt